phpstan fixes

[thomasvargiu]

This PR fixes some issues with phpdoc and types. Used phpstan to static analyse the code.

Added phpstan in CI build.

[malukenho]

I'd stick with string[].

[thomasvargiu]

you're right, my mistake 👍

[thomasvargiu]

I've added phpstan in CI build and fixed some wrong uses of array_key_exists with ArrayObject.

[Ocramius]

👍

[Ocramius]

@thomasvargiu I've just noticed that this targets master: can you change it to develop? Since it's an improvement, it needs to target the next minor or major.

[Ocramius]

Please rebase, don't merge :)

[thomasvargiu]

My fault, I'm still working on it

[thomasvargiu]

@Ocramius
I have just one issue that I want to fix:

------ ----------------------------------------------------------------------------------------------------------------------------
  Line   src/AbstractPluginManager.php
 ------ ----------------------------------------------------------------------------------------------------------------------------
  130    Parameter #1 $instance of method Zend\ServiceManager\AbstractPluginManager::validate() expects object, array|object given.
 ------ ----------------------------------------------------------------------------------------------------------------------------

I think we should change PHPDoc of $instance parameter in Zend\ServiceManager\PluginManagerInterface::validate() from object to mixed because we know that services config key can contain anything.

But I'm not sure about this change. We can also ignore the error at the moment.

What do you think about it?

[weierophinney]

I've noted that phpstan should only be added for Travis jobs that require it, not as a general dev dependency.

Additionally, I'll note that a large number of the changes presented here are present in other pull requests; you'll likely need to rebase and run again once those are in place.

[weierophinney]

This should be added programmatically in the .travis.yml when PHPSTAN_TEST is selected.

[thomasvargiu]

Done

[thomasvargiu]

I've noted that phpstan should only be added for Travis jobs that require it, not as a general dev dependency.

Done.

Additionally, I'll note that a large number of the changes presented here are present in other pull requests; you'll likely need to rebase and run again once those are in place.

It's not a problem, when I open it I though that it could be useful before to introduce strict type hints. We can merge other PRs and then rebase it.

[Xerkus]

Rescheduling to 4.0.0 since it targets develop in turn targeting 4.0

[thomasvargiu]

@weierophinney I rebased it, updated phpstan, done some other fixes.

I also allowed array in the PluginManager validate() method.

[weierophinney]

This repository has been closed and moved to laminas/laminas-servicemanager; a new issue has been opened at laminas/laminas-servicemanager#7.

[weierophinney]

This repository has been moved to laminas/laminas-servicemanager. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

• Squash all commits in your branch (git rebase -i origin/{branch})
• Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
• Run the laminas/laminas-migration tool on the code.
• Clone laminas/laminas-servicemanager to another directory.
• Copy the files from the second bullet point to the clone of laminas/laminas-servicemanager.
• In your clone of laminas/laminas-servicemanager, commit the files, push to your fork, and open the new PR.
  We will be providing tooling via laminas/laminas-migration soon to help automate the process.