Skip to content
This repository has been archived by the owner on Nov 23, 2024. It is now read-only.

Add POSIX compatibility #153

Closed
wants to merge 1 commit into from
Closed

Add POSIX compatibility #153

wants to merge 1 commit into from

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Apr 24, 2020

Hi,

it's almost a rewrite of the shell script for helm script. I hope the new maintainer / well-known company @zendesk will have some time for this project.

I remove all bash related shell code and replace it with POSIX feature. The script will run on almost any posix compatible shell. The scripts is also compliant to shellcheck.

ZSH (MacOS default shell) and ash (Alpine default shell) should now out of the box supported. gnu-getops is not required anymore.

All tests from test.sh are green under MacOS 10.15.4 (zsh, bash 3.2.57) and Alpine 3.11 (ash)

Additional features:

All helm commands are supported now. Before this only install|template|upgrade|lint|diff are supported. If plugins like kubeval are installed this script need to be modified. The PR remove the limitation.

I recommend split view and ignore whitespaces for best experience to get all changes. https://github.com/zendesk/helm-secrets/pull/153/files?diff=split&w=1

Includes/Resolves/Fixes:

@jkroepke jkroepke force-pushed the alpine branch 3 times, most recently from 4eb3e3b to 1a9ce3b Compare April 24, 2020 01:00
@jkroepke
Copy link
Contributor Author

I'm gonna start to maintain an own fork.
https://github.com/jkroepke/helm-secrets

If you still interest into this PR, contact me.

@jkroepke jkroepke closed this Apr 27, 2020
@jkroepke jkroepke deleted the alpine branch April 27, 2020 14:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant