Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ZIP 32 arbitrary key derivation #19

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Implement ZIP 32 arbitrary key derivation #19

merged 2 commits into from
Oct 22, 2024

Conversation

str4d
Copy link
Collaborator

@str4d str4d commented Oct 1, 2024 •
edited
Loading

Depends on zcash/zcash_spec#6.

@str4d str4d mentioned this pull request Oct 1, 2024
Draft
str4d
str4d commented Oct 1, 2024
View reviewed changes
src/hardened_only.rs Outdated Show resolved Hide resolved
str4d
str4d commented Oct 1, 2024
View reviewed changes
src/hardened_only.rs Outdated Show resolved Hide resolved
@str4d str4d force-pushed the arb-keys branch 3 times, most recently from a564f8c to 2dcc40b Compare October 2, 2024 16:19
daira
daira approved these changes Oct 8, 2024
View reviewed changes
Copy link

@daira daira left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK modulo clippy failures.

@str4d
Copy link
Collaborator Author

str4d commented Oct 18, 2024

Force-pushed to fix impl mistake.

nuttycom
nuttycom approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK b97f065

nuttycom
nuttycom approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 3c9086a

@str4d
Copy link
Collaborator Author

str4d commented Oct 22, 2024

Published 3c9086a as v0.1.2.

@str4d str4d merged commit f4e1c2f into master Oct 22, 2024
21 checks passed
@str4d str4d deleted the arb-keys branch October 22, 2024 20:45
This was referenced Nov 13, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira approved these changes

@nuttycom nuttycom nuttycom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@str4d @nuttycom @daira