Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rely on drop() to perform final accumulation step #83

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ebfull
Copy link
Collaborator

@ebfull ebfull commented Aug 14, 2018

The MultiEq API relies on drop, which is not guaranteed to run. By wrapping the logic in a closure we ensure the final accumulation step must be performed to proceed with execution.

Copy link

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Existing tests should cover.

stefandeml pushed a commit to stefandeml/sapling-crypto that referenced this pull request Jul 5, 2019
feat(example): print number of constraints on bench
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants