intl: support language prefixes for all URLs #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zbycz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no prefix is detected, the app is used as before (cookie or accept). It leverages the nextjs's default locale called
default.When prefix is detected, it forces the selected language and sets cookie.
This could
osmapp.org/cs/node/123(not that useful)Alternative urls:
osmapp.org/cs/node/123osmapp.org/node/123/enosmapp.org/node/123?lang=cscs.osmapp.org/node/123<- not sure how to do on vercelQuestions:no prefix = english OR autodetect?use prefix/query only as setter&remove OR leave it in app consistently