Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove asciitree dependency #2511

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Remove asciitree dependency #2511

merged 2 commits into from
Nov 21, 2024

Conversation

normanrz
Copy link
Contributor

Remove asciitree dependency. I couldn't find any use of it in the codebase.

Fixes #1370
Contributes to #2391

@normanrz normanrz self-assigned this Nov 21, 2024
.pre-commit-config.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@d-v-b d-v-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for cleaning this up!

@normanrz
Copy link
Contributor Author

cc @oanegros

@d-v-b d-v-b merged commit 3dd04ce into main Nov 21, 2024
31 checks passed
@normanrz normanrz deleted the no-asciitree branch November 21, 2024 22:16
@jakirkham
Copy link
Member

Would we want to get this one too?

Today, Zarr-Python has the following required dependencies:
.. code:: python
dependencies = [
'asciitree',
'numpy>=1.20,!=1.21.0',
'fasteners',
'numcodecs>=0.10.0',
]

It's possible the answer is no. Just wanted to ask for completeness

@d-v-b
Copy link
Contributor

d-v-b commented Nov 21, 2024

I think that statement is scoped to the time when it was written, which was a time when those were in fact the minimum dependencies. So removing asciitree would actually make the document inaccurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

asciitree has no wheels
3 participants