Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't normalize paths in StorePath.delete_dir #2493

Merged
merged 2 commits into from
Nov 15, 2024
Merged

don't normalize paths in StorePath.delete_dir #2493

merged 2 commits into from
Nov 15, 2024

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Nov 15, 2024

StorePath.delete_dir does not need to normalize paths, because it calls store.delete_dir, which does its own path normalization.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@d-v-b d-v-b requested a review from jhamman November 15, 2024 16:57
jhamman
jhamman approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@d-v-b d-v-b merged commit 26b6d8d into zarr-developers:main Nov 15, 2024
26 checks passed
@d-v-b d-v-b deleted the fix/storepath-delete-dir branch November 15, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamman jhamman jhamman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-v-b @jhamman