Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing to most Array properties #1711

Closed
wants to merge 2 commits into from

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Mar 18, 2024

This adds returns typing to most properties of Array.

TODO:

  • [n/a] Add unit tests and/or doctests in docstrings
  • [n/a] Add docstrings and API docs for any new/modified user-facing classes and functions
  • [n/a] New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.99%. Comparing base (6105ef2) to head (ba56199).

❗ Current head ba56199 differs from pull request most recent head af0d5fa. Consider uploading reports for the commit af0d5fa to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1711   +/-   ##
=======================================
  Coverage   99.98%   99.99%           
=======================================
  Files          38       38           
  Lines       14640    14571   -69     
=======================================
- Hits        14638    14570   -68     
+ Misses          2        1    -1     
Files Coverage Δ
zarr/core.py 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

zarr/core.py Outdated Show resolved Hide resolved
@dstansby dstansby closed this Apr 24, 2024
@dstansby dstansby deleted the type-array-props branch April 24, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants