Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds astype config for Delta in Zarr 3 wrapper #664

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Adds astype config for Delta in Zarr 3 wrapper #664

merged 2 commits into from
Dec 2, 2024

Conversation

normanrz
Copy link
Contributor

@normanrz normanrz commented Dec 2, 2024

Adds astype config for Delta in Zarr 3 wrapper.
Fixes #663

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (f43449b) to head (ff6b471).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #664   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          62       62           
  Lines        2721     2736   +15     
=======================================
+ Hits         2719     2734   +15     
  Misses          2        2           
Files with missing lines Coverage Δ
numcodecs/tests/test_zarr3.py 100.00% <100.00%> (ø)
numcodecs/zarr3.py 100.00% <100.00%> (ø)

docs/release.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@rabernat rabernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks for the quick action.

@normanrz normanrz merged commit d8a0a55 into main Dec 2, 2024
45 checks passed
@normanrz normanrz deleted the fix-663 branch December 2, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numcodecs Delta filter with astype not working with Zarr 3
3 participants