Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ts): Extract HttpRequestOptionsWithUrl, add to middleware #924

Merged
merged 1 commit into from
Nov 25, 2024
Merged

chore(ts): Extract HttpRequestOptionsWithUrl, add to middleware #924

merged 1 commit into from
Nov 25, 2024
+8 −8

Conversation

tkcranny
Copy link
Collaborator

This extends the HttpRequestOptions interface with a variant with a concrete url explicitly set, which is used in some invocations of z.request, but also in before middleware.

@tkcranny tkcranny requested a review from a team as a code owner November 25, 2024 06:42
@tkcranny tkcranny self-assigned this Nov 25, 2024
@rnegron rnegron merged commit 9310d6e into main Nov 25, 2024
14 checks passed
@rnegron rnegron deleted the IQQ-2144-middleware-types branch November 25, 2024 13:05
@kola-er kola-er mentioned this pull request Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnegron rnegron rnegron approved these changes

Assignees

@tkcranny tkcranny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkcranny @rnegron