chore(ts): Update bundle.meta typings [IQQ-2105] #922
Merged
+60
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kola-er
reviewed
Nov 21, 2024
Co-authored-by: Kola Erinoso <[email protected]>
kreddlear
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
@tkcranny looks good! If you're curious, looks like for timezone, it always exists but can be None, based on this code, so your existing code is correct 👍 (as compared with withSearch)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
bundle.metatypes with clearer docs, deprecation markings, and support for the newtimezoneandwithSearchfields.I've followed the Core Docs on this subject, but if anything is not strictly correct with the platform's behaviour I'll be happy to adjust.
meta.zap, and all of the innerid,user, anduser.timezonepropertiesisTestingAuth, because the docs say "Legacy property".withSearch: string | undefined. Docs unclear if this is always set and will bestring | undefined, or if the key is present it will be a valid string, meaningwithSearch?: stringwould be better.timezone: string | null. Same as above.isBulkRead: Unchanged, but curious if it should be marked deprecated or internal only too.