Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core) - PDE-5490 calling lambda callback doesnt wait for event loop #904

Merged
merged 6 commits into from
Oct 31, 2024
+6 −0
Merged

feat(core) - PDE-5490 calling lambda callback doesnt wait for event loop #904

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8c40940
callback doesnt wait for event loop
standielpls Oct 25, 2024
d114e07
Read val from event
standielpls Oct 29, 2024
9de7404
change name of event to match backend
standielpls Oct 30, 2024
d5e0def
Better msg
standielpls Oct 30, 2024
82a1ac1
use opt out name
standielpls Oct 30, 2024
6d687d7
not always true
standielpls Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/core/src/tools/create-lambda-handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,12 @@ const createLambdaHandler = (appRawOrPath) => {
// Wait for all async events to complete before callback returns.
// This is not strictly necessary since this is the default now when
// using the callback; just putting it here to be explicit.
// In some cases, the code hangs and never exits because the event loop is not
// empty, so we can override the default behavior and exit after the app is done.
context.callbackWaitsForEmptyEventLoop = true;
if (event.skipWaitForAsync === true) {
context.callbackWaitsForEmptyEventLoop = false;
}

// replace native Promise with bluebird (works better with domains)
if (!event.calledFromCli) {
Expand Down Expand Up @@ -264,6 +269,7 @@ const createLambdaHandler = (appRawOrPath) => {
const compiledApp = schemaTools.prepareApp(appRaw);

const input = createInput(compiledApp, event, logger, logBuffer, rpc);

return app(input);
})
.then((output) => {
Expand Down
Loading