Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add multi-arch support for releases. #81

Merged
merged 5 commits into from
Nov 7, 2023

Conversation

cwboden
Copy link
Contributor

@cwboden cwboden commented Oct 26, 2023

Addresses #46.

Open to changes in the approach, though I confirmed this built locally for me on WSL2.

I elected to keep the non-multi-arch build steps around for backwards compatibility, instead introducing new *-multiarch steps that are now called from the on_release Workflow.

In addition, I updated Earthfile.md and tidied it up so it'll look nicer when rendered.

@djeebus
Copy link
Collaborator

djeebus commented Oct 26, 2023

Thanks! It looks like you made a release-binaries-multiarch, but the existing release-binaries is already multiarch (since build-binaries, which provides the binaries, is itself multiarch). Unless I'm missing something, want to remove the release-binaries-multiarch target? Everything else looks good!

@cwboden
Copy link
Contributor Author

cwboden commented Oct 30, 2023

@djeebus Updated! Let me know if there's anything else you'd like me to touch up. Cheers.

@mplachter
Copy link
Contributor

@cwboden, it looks like this got out of date with the upstream, would love to get this in let me know when you can fix it 🙇

@cwboden
Copy link
Contributor Author

cwboden commented Nov 7, 2023

@mplachter Done

Copy link
Contributor

@mplachter mplachter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@djeebus is this g2g?

@djeebus
Copy link
Collaborator

djeebus commented Nov 7, 2023

yup, looks good, thanks!

@djeebus djeebus merged commit 27b0fd3 into zapier:main Nov 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants