-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add multi-arch support for releases. #81
Conversation
Signed-off-by: Carson Boden <[email protected]>
Signed-off-by: Carson Boden <[email protected]>
Signed-off-by: Carson Boden <[email protected]>
3862136
to
fb05a13
Compare
Thanks! It looks like you made a |
Signed-off-by: Carson Boden <[email protected]>
805ef88
to
8f5bde8
Compare
@djeebus Updated! Let me know if there's anything else you'd like me to touch up. Cheers. |
@cwboden, it looks like this got out of date with the upstream, would love to get this in let me know when you can fix it 🙇 |
@mplachter Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@djeebus is this g2g?
yup, looks good, thanks! |
Addresses #46.
Open to changes in the approach, though I confirmed this built locally for me on WSL2.
I elected to keep the non-multi-arch build steps around for backwards compatibility, instead introducing new
*-multiarch
steps that are now called from theon_release
Workflow.In addition, I updated
Earthfile.md
and tidied it up so it'll look nicer when rendered.