Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytorch version alad update #590

Merged
merged 4 commits into from
Jul 4, 2024
Merged

Conversation

Bourne227
Copy link
Contributor

@Bourne227 Bourne227 commented Jun 25, 2024

All Submissions Basics:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you checked all Issues to tie the PR to a specific one?

All Submissions Cores:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?
  • Does your submission pass tests, including CircleCI, Travis CI, and AppVeyor?
  • Does your submission have appropriate code coverage? The cutoff threshold is 95% by Coversall.

New Model Submissions:

  • Have you created a .py in ~/pyod/models/?
  • Have you created a _example.py in ~/examples/?
  • Have you created a test_.py in ~/pyod/test/?
  • Have you lint your code locally prior to submission?

@coveralls
Copy link

coveralls commented Jun 28, 2024

Pull Request Test Coverage Report for Build 9656255470

Details

  • 102 of 143 (71.33%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 94.13%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyod/models/alad.py 102 143 71.33%
Files with Coverage Reduction New Missed Lines %
pyod/models/alad.py 5 70.64%
Totals Coverage Status
Change from base Build 9622957290: -0.04%
Covered Lines: 9332
Relevant Lines: 9914

💛 - Coveralls

Copy link
Contributor Author

@Bourne227 Bourne227 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests back, probably need a rerun for testing coverage.

@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9720224673

Details

  • 166 of 201 (82.59%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 94.303%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyod/models/alad.py 108 143 75.52%
Files with Coverage Reduction New Missed Lines %
pyod/models/alad.py 4 77.06%
Totals Coverage Status
Change from base Build 9622957290: 0.1%
Covered Lines: 9403
Relevant Lines: 9971

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 3, 2024

Pull Request Test Coverage Report for Build 9769535622

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 197 of 214 (92.06%) changed or added relevant lines in 2 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.5%) to 94.699%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyod/test/test_alad.py 70 71 98.59%
pyod/models/alad.py 127 143 88.81%
Files with Coverage Reduction New Missed Lines %
pyod/models/alad.py 1 90.83%
pyod/utils/torch_utility.py 2 97.89%
pyod/models/mo_gaal.py 3 97.03%
Totals Coverage Status
Change from base Build 9622957290: 0.5%
Covered Lines: 9646
Relevant Lines: 10186

💛 - Coveralls

@yzhao062 yzhao062 merged commit 0dfb32f into yzhao062:development Jul 4, 2024
1 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants