Fix #1602: Error with diagramsnet, when using parameters #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy the same workaround as in mermaid https://github.com/yuzutech/kroki/blob/main/mermaid/src/index.js#L28-L29
|
Could you please add a smoke test in https://github.com/yuzutech/kroki/blob/main/ci/tests/smoke.js#L35 ? You'll need to add a new entry with an option (for instance, |
|
Okay, i hope i got this. But i do not know, how to run them... Maybe it is already enough? |
|
CI will run it so if the build is green we are good to go 🤞 |
|
All good, thanks for your contribution! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1602
Copy the same workaround as in mermaid https://github.com/yuzutech/kroki/blob/main/mermaid/src/index.js#L28-L29