Support Record type #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amutake
reviewed
Mar 1, 2019
| @@ -7,3 +7,6 @@ | |||
|
|
|||
| %% test case for opaque decl | |||
| -opaque int() :: integer(). | |||
|
|
|||
| -record(state, {name :: string(), param :: term()}). | |||
| -type record_as_type(A) :: #state{param :: A}. | |||
There was a problem hiding this comment.
Could you add the purpose of this test-case as a comment? e.g., %% test case for record type and record field type
yoshihiro503
force-pushed
the
record_type
branch
from
80679f1
to
d498944
Compare
amutake
reviewed
Mar 1, 2019
lib/abstract_format.ml
Outdated
| Sf.Integer line; | ||
| Sf.Atom "record"; | ||
| Sf.List ( | ||
| Sf.Tuple(3, [Sf.Atom "atom"; Sf.Integer line_field_types; Sf.Atom name]) |
There was a problem hiding this comment.
line_field_types seems to be line of record name. So could you rename line_field_types to line_name?
There was a problem hiding this comment.
That's right, I fixed it.
amutake
approved these changes
Mar 1, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
See also #54
Example