Support Record Expression #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amutake
reviewed
Feb 27, 2019
lib/abstract_format.ml
Outdated
| begin match record_field_of_sf sf with | ||
| | Ok (RecordField {line; field_name; ty=None; default_expr=Some e}) -> | ||
| (line, field_name, e) |> return | ||
| | Ok _ -> failwith "cannot reach here" |
There was a problem hiding this comment.
Could you use Err.Invalid_input?
lib/abstract_format.ml
Outdated
| begin match record_field_of_sf sf with | ||
| | Ok (RecordField {line; field_name; ty=None; default_expr=Some e}) -> | ||
| (line, field_name, e) |> return | ||
| | Ok _ -> failwith "cannot reach here" |
amutake
reviewed
Feb 27, 2019
lib/abstract_format.ml
Outdated
| | Error e -> Error e | ||
| end | ||
| in | ||
| let%bind expr = sf_expr |> expr_of_sf in |
There was a problem hiding this comment.
Could you add |> track ~loc:[%here]?
amutake
reviewed
Feb 27, 2019
lib/abstract_format.ml
Outdated
| | Ok (RecordField {line; field_name; ty=None; default_expr=Some e}) -> | ||
| (line, field_name, e) |> return | ||
| | Ok _ -> | ||
| Err.create ~loc:[%here] (Err.Invalid_input ("cannot reach here", sf)) |> Result.fail |
There was a problem hiding this comment.
Could you make error message more detailed? e.g., "record field must have field name and expression" 🙏
lib/abstract_format.ml
Outdated
| | Ok (RecordField {line; field_name; ty=None; default_expr=Some e}) -> | ||
| (line, field_name, e) |> return | ||
| | Ok _ -> | ||
| Err.create ~loc:[%here] (Err.Invalid_input ("cannot reach here", sf)) |> Result.fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #54
Support following expressions.
#user{name = "Taro", admin = true}U#user.name#user.nameU#user{admin = true}