Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rtmps protocol on client connection #65

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

jbreich
Copy link
Contributor

@jbreich jbreich commented Jul 10, 2024

The aim here is to support rtmps protocol with the library (rtmp using a TLS connection). No special modification is needed on the server side because we can already provide a net.Listener which could use TLS or not, but on the client side a net.Dialer is used preventing from using TLS.
So I added a new method TLSDial to support this case even if it not perfect. I could have re-used the already existing Dial method to support both rtmp and rtmps but the problem is that I need to provide an extra configuration tls.Config to make it work. Another possibility would be to put this config directly in the rtmp.ConnConfig but the problem is that it is used for both the client & server connection, and it would only be necessary for a client connection. I can update my PR if you think it is a better approach or if you see another one ?

I also removed the function makeValidAddr because it is not used but I can put it back if you think it is needed

Copy link
Owner

@yutopp yutopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my late response...

LGTM. Thank you for your contribution!

@yutopp yutopp merged commit c7fee44 into yutopp:master Jul 15, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants