-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] spherical volume rendering experiment (do not merge) #84
Draft
chrishavlin
wants to merge
40
commits into
yt-project:main
Choose a base branch
from
chrishavlin:another_attempt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der functionality based on dataset geometry
for more information, see https://pre-commit.ci
note to self: use the offscreen rendering for debugging. much easier to isolate issues. e.g., the actual ray tracing attempt in this PR returns a blank image.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based off of #64
It attempts to actually use the ray-voxel intersections now calculated in #64 in evaluating the textures rather than evaluating the textures at the vertex points. The configuration that I've pushed here evaluates a single point at the midpoint between the two intersections, though it contains some code for full ray tracing.
Currently working on:
Issue 1: voxels with phi values at y<0 are discarded as having no intersections. This isn't right. I think I ruled out the coordinate transformations within the shader as the source of the problem.
Issue 2: when actually attempting to step along between the intersection points, rendering can start to lag and occasionally crash. This could simply be that the shader is too complex (there's still too many nested if statements, though it is slightly better than in #64) and I'm hitting a memory wall. But until I fix Issue 1 it's a little hard to optimize the shader.
Note: after I work out the kinks here, I'll continue development in #64.