-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Textured planes for slices, cutting planes and projections #14
base: main
Are you sure you want to change the base?
Conversation
@chrishavlin Could you em |
just pushed -- had forgotten to run isort and was using a different black version than what the checks here are using. but those should be fixed now! |
oh and just a note for myself to come back to: I'm not 100% I have the orientation of the resulting planes correct. I need to test out some slices on less symmetrical datasets. |
ce1780d
to
927aaa7
Compare
for more information, see https://pre-commit.ci
11e941e
to
388bf00
Compare
reminder to myself when I come back to this next: I don't think the orientation handling going from a FRB to the world coords is currently correct... use slices of the coords to check. |
This is a more straightforward implementation than #12 (which I will close in favor of this) that adds the ability to add 2d YTDataContainer objects (e.g.,
ds.slice
,ds.cutting
,ds.proj
) to a 3D scene. This implementation generates a frb and uses the data as a 2D texture.Given #13, this is probably most useful for plotting the results of a projection along with a volume rendering:
But there may be some cases where adding independent slices is advantageous. Another example (from
examples/plane_textures_multiple.py
) with projections on the bounding-box faces and a slice and cutting plane on the interior:There still seems to be some face culling or z-ordering issue that I haven't figured out yet: when added to an existing volume rendering, planes are not visible from all perspectives (e.g., when running
examples/amr_volume_rendering_with_planes.py
and rotating, planes with disappear/reappear). Adding aGL.glDisable(GL.GL_CULL_FACE)
fixes the issue (but I haven't committed that change, as there's probably a better way to fix it).