BUG: fix indexing error in fill_region_float #4970
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to figure out why the final row of pixels in the following plot seem to have elevated values:
The elevated values are not super obvious here... but i've been doing some experiments stitching together arbitrary grid objects into zarr files (over in yt-project/yt_experiments#10) and found some artifacts aligned with the boundaries of my chunks:
In any case, reading through
fill_region_float
, I noticed this line where there seems to be an indexing error. With the change on this branch, the above plots become