BUG: fix future incompatibility with numpy 2.0 (numpy.core isn't public API) #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removing |
neutrinoceros
force-pushed
the
hotfix_numpy2.0_core
branch
from
fecd2a1
to
fc84065
Compare
|
@jzuhone may I have your opinion here ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix an on-going failure in bleeding-edge CI
Context:
numpy/numpy#24634
The comment I'm removing is from #204. Local testing suggests that it's not necessary anymore (tests introduced in the same PR still pass), I suspect this is due to bumping our minimal requirements for numpy since that PR.
Opening as a draft for validation against the full CI. If all goes well, I'll try to remove
unyt_array.__pow__completely