Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored for PHP 8 #255

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open

Refactored for PHP 8 #255

wants to merge 40 commits into from

Conversation

Matys333
Copy link

We were using this package in our warehouse system application and we wanted to upgrade to Symfony 6.4, but we did not want to use any other package, so we forked it and refactored it along with the GraphQLBundle (there is PR as well).
Refactored the code to PHP 8 standards, added type declarations and various fixes that came along with it.
It has been now tested for some time on our live application, which deals with tons of requests and everything works fine, but I'm not saying there cannot be some problems for others.
With that we would be open to maintain it from now on, please let me know.
Thanks

@Jalle19
Copy link
Collaborator

Jalle19 commented May 30, 2024

I'm certainly open to letting you maintain this project if you find it useful. @viniychuk is the only one (I think) who can add new collaborators though.

@Matys333 Matys333 changed the title Refactored for Symfony 6 / PHP 8 Refactored for PHP 8 Jun 5, 2024
@Jalle19
Copy link
Collaborator

Jalle19 commented Jun 17, 2024

Ping @viniychuk

@Jalle19
Copy link
Collaborator

Jalle19 commented Jun 20, 2024

I may have the project owner's email address somewhere, I'll see if I can get a hold of him that way.

@Matys333
Copy link
Author

Thanks @Jalle19.

# Conflicts:
#	src/Type/ListType/AbstractListType.php
#	src/Type/ListType/ListType.php
#	src/Type/Object/AbstractObjectType.php
@Jalle19
Copy link
Collaborator

Jalle19 commented Aug 30, 2024

I can't reach the original maintainer anymore. I think it's probably best if you fork this and publish it under another name to Composer.

@viniychuk
Copy link
Member

viniychuk commented Aug 30, 2024 via email

@Jalle19
Copy link
Collaborator

Jalle19 commented Aug 31, 2024

Awesome!

@Jalle19
Copy link
Collaborator

Jalle19 commented Sep 1, 2024

@Matys333 feel free to merge

@Matys333
Copy link
Author

Hey guys, sorry, I was off past two weeks.
@viniychuk The invitation has expired, can you please send it again, and for the bundle as well? Thanks!
Also, I'll have tests ready soon too, will merge after that and everything else with some changes to the readme, so after everything is ready 100%.

@Jalle19
Copy link
Collaborator

Jalle19 commented Sep 11, 2024

I don't seem to have the ability to add maintainers, even though @viniychuk said he'd add that 🤷 Let's hope he responds again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants