-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored for PHP 8 #255
base: master
Are you sure you want to change the base?
Refactored for PHP 8 #255
Conversation
…ument, fix toString for AbstractType for null types
Use class_exists to check for class existence
Use AbstractInputObjectType in typing
Use DateTimeType for DateType implementation
I'm certainly open to letting you maintain this project if you find it useful. @viniychuk is the only one (I think) who can add new collaborators though. |
Ping @viniychuk |
I may have the project owner's email address somewhere, I'll see if I can get a hold of him that way. |
Thanks @Jalle19. |
# Conflicts: # src/Type/ListType/AbstractListType.php # src/Type/ListType/ListType.php # src/Type/Object/AbstractObjectType.php
I can't reach the original maintainer anymore. I think it's probably best if you fork this and publish it under another name to Composer. |
Hey there folks,
All of this was in spam. Adding you as a collaborator and sharing the permissions to add more!
… On Aug 30, 2024, at 8:16 AM, Sam Stenvall ***@***.***> wrote:
I can't reach the original maintainer anymore. I think it's probably best if you fork this and publish it under another name to Composer.
—
Reply to this email directly, view it on GitHub <#255 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKYZ5MWJULGBYQRTGDIZILZUBPCFAVCNFSM6AAAAABIQPRIJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRRGA2DSNRTGY>.
You are receiving this because you were mentioned.
|
Awesome! |
@Matys333 feel free to merge |
Hey guys, sorry, I was off past two weeks. |
I don't seem to have the ability to add maintainers, even though @viniychuk said he'd add that 🤷 Let's hope he responds again |
We were using this package in our warehouse system application and we wanted to upgrade to Symfony 6.4, but we did not want to use any other package, so we forked it and refactored it along with the GraphQLBundle (there is PR as well).
Refactored the code to PHP 8 standards, added type declarations and various fixes that came along with it.
It has been now tested for some time on our live application, which deals with tons of requests and everything works fine, but I'm not saying there cannot be some problems for others.
With that we would be open to maintain it from now on, please let me know.
Thanks