-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add kill test #2996
base: main
Are you sure you want to change the base?
add kill test #2996
Conversation
@YamasouA please sign your commits. The instructions can be found at https://github.com/youki-dev/youki/pull/2996/checks?check_run_id=33094881373 |
Signed-off-by: Akiyama <[email protected]>
Signed-off-by: Akiyama <[email protected]>
@YJDoc2 |
let kill_test = ConditionalTest::new( | ||
"test_kill_container", | ||
Box::new(|| true), | ||
Box::new(run_kill_test_cases), | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use normal test instead of ConditionalTest here, that will not require a conditional function.
Hey @YamasouA , thanks for the PR. I have taken a basic look, and want to request a change - Can I request you to change this code to split each test condition into its own testcase? So it will be one function for testing kill without id, one for kill non-existing container and so on. |
part of #361
I implement kill test case in runtime-tools to youki.