Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MaybeDone from impl Join for array #72

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Conversation

yoshuawuyts
Copy link
Owner

Ref #22. Moves us away from MaybeDone for array::join.

Performance

Performance appears to remain about equal as it was before, with a performance diff which can easily be attributed to noise:

❯ critcmp main patch  -f array::join
group               main                                   patch
-----               ----                                   -----
array::join 10      1.03   589.1±26.71ns        ? ?/sec    1.00   571.7±12.23ns        ? ?/sec
array::join 100     1.00      3.7±0.03µs        ? ?/sec    1.05      3.8±0.16µs        ? ?/sec
array::join 1000    1.00     33.0±0.34µs        ? ?/sec    1.03     33.8±1.01µs        ? ?/sec

@yoshuawuyts yoshuawuyts changed the title Remove MaybeDone for array::join Remove MaybeDone from impl Join for array Nov 14, 2022
@yoshuawuyts yoshuawuyts merged commit 2d35a6b into main Nov 16, 2022
@delete-merged-branch delete-merged-branch bot deleted the no-maybedone-join branch November 16, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants