Revert punycode to 1.4.x which supports pre ES6 format #20284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mtangoo
commented
Nov 26, 2024
mtangoo
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fixed issues | 20283 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20284 +/- ##
============================================
- Coverage 64.84% 62.83% -2.01%
Complexity 11399 11399
============================================
Files 430 430
Lines 37134 37134
============================================
- Hits 24080 23335 -745
- Misses 13054 13799 +745 ☔ View full report in Codecov by Sentry. |
Arhell
approved these changes
Nov 27, 2024
How did I miss this. Should I create new PR just to add that? @samdark Please advise on how to sort this mess out |
mtangoo
added a commit
to mtangoo/yii2
that referenced
this pull request
Nov 27, 2024
mtangoo
added a commit
that referenced
this pull request
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.