Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix NRC changed their apis #718

Merged
merged 2 commits into from
Sep 29, 2024
Merged

feat: fix NRC changed their apis #718

merged 2 commits into from
Sep 29, 2024

Conversation

yihong0618
Copy link
Owner

@yihong0618 yihong0618 commented Sep 28, 2024

close: #717

Signed-off-by: yihong0618 <[email protected]>
Copy link

vercel bot commented Sep 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
running-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2024 11:28am

@yihong0618 yihong0618 changed the title doc: doc for new nrc sync feat: fix nrc Changed their apis Sep 28, 2024
Copy link
Collaborator

@ben-29 ben-29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
ps: I haven't tested because I haven't used NRC

#
# access_token = response.json()["access_token"]
access_token = "The content of 'access_token' that you just copied."
# HINT: if you have old nrc refresh_token un comments this liens it still works
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: lines

Signed-off-by: yihong0618 <[email protected]>
@yihong0618 yihong0618 merged commit 5cc03b4 into master Sep 29, 2024
9 of 10 checks passed
@yihong0618 yihong0618 changed the title feat: fix nrc Changed their apis feat: fix NRC changed their apis Sep 29, 2024
@yihong0618 yihong0618 deleted the fix_nrc_new_api branch September 29, 2024 11:29
ben-29 added a commit to ben-29/workouts_page that referenced this pull request Sep 29, 2024
* refs/heads/upstream:
  feat: fix nrc Changed their apis (yihong0618#718)
  feat: conditionally output analysis JS only in Vercel environment (yihong0618#715)
  ignore the year which has no running data when drawing github.svg (yihong0618#712)
  Fix AttributeError in Activity class (yihong0618#714)
  doc: fix typo close yihong0618#704
  Some Front Optimization for Keep indoor data (yihong0618#709)
  Add new runner (yihong0618#707)
  feat: adding illustration for special tracks  (yihong0618#705)

# Conflicts:
#	run_page/generator/__init__.py
#	run_page/joyrun_sync.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NRC down
2 participants