-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fix NRC changed their apis #718
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yihong0618 <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yihong0618
requested review from
zhaohongxuan,
ben-29,
shaonianche and
higuoxing
September 28, 2024 10:29
yihong0618
changed the title
doc: doc for new nrc sync
feat: fix nrc Changed their apis
Sep 28, 2024
ben-29
approved these changes
Sep 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ps: I haven't tested because I haven't used NRC
run_page/nike_sync.py
Outdated
# | ||
# access_token = response.json()["access_token"] | ||
access_token = "The content of 'access_token' that you just copied." | ||
# HINT: if you have old nrc refresh_token un comments this liens it still works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: lines
Signed-off-by: yihong0618 <[email protected]>
yihong0618
changed the title
feat: fix nrc Changed their apis
feat: fix NRC changed their apis
Sep 29, 2024
ben-29
added a commit
to ben-29/workouts_page
that referenced
this pull request
Sep 29, 2024
* refs/heads/upstream: feat: fix nrc Changed their apis (yihong0618#718) feat: conditionally output analysis JS only in Vercel environment (yihong0618#715) ignore the year which has no running data when drawing github.svg (yihong0618#712) Fix AttributeError in Activity class (yihong0618#714) doc: fix typo close yihong0618#704 Some Front Optimization for Keep indoor data (yihong0618#709) Add new runner (yihong0618#707) feat: adding illustration for special tracks (yihong0618#705) # Conflicts: # run_page/generator/__init__.py # run_page/joyrun_sync.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #717