Implement basic route-id data type & use remix config.appDirectory. #75
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
@dawnmist thank you! Could you please fix the CI error? |
|
It should be fixed now. :) |
dawnmist
changed the title
dawnmist
force-pushed
the
add-route-id-validation
branch
from
c728569
to
3bc4d48
Compare
|
Is there a way to see what the actual Windows failures are (what the difference in the snapshot is)? |
| test("build customPaths routes", async () => { | ||
| await build(path.resolve(__dirname, "../../fixture/customPaths"), { outputDirPath: "./types/remix-routes", watch: false, strict: false }); | ||
| expect( | ||
| fs.readFileSync(path.resolve( __dirname, "../../fixture/customPaths/types/remix-routes/remix-routes.d.ts"), "utf8"), |
There was a problem hiding this comment.
You can try printing out the content of remix-routes.d.ts to see what's generated on windows.
There was a problem hiding this comment.
Next run should show that now.
I'm hoping it's not something like line-feed differences between linux & Windows.
There was a problem hiding this comment.
Argh. Sorry for the copy-paste error on the v1 route console log. Pushed the correct file path to log.
| @@ -5,14 +5,30 @@ import { build } from '../cli'; | |||
|
|
|||
| test('build v1 routes', async () => { | |||
| await build(path.resolve(__dirname, '../../fixture/v1'), { outputDirPath: './node_modules', watch: false, strict: false }); | |||
| console.log(fs.readFileSync( | |||
| path.resolve(__dirname, "../../fixture/v2/node_modules/remix-routes.d.ts"), "utf8"), | |||
There was a problem hiding this comment.
| path.resolve(__dirname, "../../fixture/v2/node_modules/remix-routes.d.ts"), "utf8"), | |
| path.resolve(__dirname, "../../fixture/v1/node_modules/remix-routes.d.ts"), "utf8"), |
dawnmist
force-pushed
the
add-route-id-validation
branch
2 times, most recently
from
1055829
to
8dc799f
Compare
|
Great! CI is passing now. Could you please remove those temporary console.log statements, once that's done, we'll be ready to merge. |
Addresses [Suggestion]: Typechecking route id's yesmeck#39
The function return is specifying it as a tuple, so 'as const' isn't needed to get typescript to treat it as a tuple, and is causing issues with readonly vs mutable types.
As it was being missed
dawnmist
force-pushed
the
add-route-id-validation
branch
from
8dc799f
to
0f691cc
Compare
I've done a rebase and removed the commit with the console logs. It should 🤞🏻 be good to go now. |
|
Published as [email protected]. Cheers! |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
appDirectorysettingconfig.appDirectoryresides based on-ooutput directory.config.appDirectorypath and multiple depth-opath.