Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change script/clean.py target path to relative path #92 #93

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

cokia
Copy link

@cokia cokia commented Aug 20, 2020

script/clean.py use absolute path ("/Users/brockelmore/YAM/build/contracts") to target dir.
This is a code that does not work for users.

So I changed to relative path (dirname(dirname(abspath(__file__))) + "/build/contracts/")

#92

@cokia cokia changed the title change script/clean.py target path to relative path change script/clean.py target path to relative path #92 Aug 21, 2020
Copy link
Contributor

@junhoyeo junhoyeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a typo

scripts/clean.py Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
Copy link
Contributor

@junhoyeo junhoyeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add spaces between operators for better readability

scripts/clean.py Outdated Show resolved Hide resolved
scripts/clean.py Outdated Show resolved Hide resolved
cokia and others added 2 commits August 21, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants