XWIKI-22631: color theme list disorganized after changing color theme #3671
+30
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated the layout * Simplified the architecture of the page content (notably replaced a clearfix hack with a flex)
* Updated the layout * Simplified the architecture of the page content (notably replaced a clearfix hack with a flex) * Updated the pageobject to account for the small changes in HTML
manuelleduc
reviewed
Nov 22, 2024
...heme/xwiki-platform-flamingo-theme-ui/src/main/resources/FlamingoThemesCode/WebHomeSheet.xml
Show resolved
Hide resolved
manuelleduc
reviewed
Nov 22, 2024
...heme/xwiki-platform-flamingo-theme-ui/src/main/resources/FlamingoThemesCode/WebHomeSheet.xml
Show resolved
Hide resolved
manuelleduc
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22631
Changes
Description
Screenshots & Video
Comparison of displays. There are minor changes, but IMO these are slight improvements.
Executed Tests
Manual tests, see above. Checking the new style with the same conditions, I could not reproduce the weird out of line overflow that happenned before.
After building the changes with
mvn clean install -f xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-theme/xwiki-platform-flamingo-theme-uiandmvn clean install -f xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-theme/xwiki-platform-flamingo-theme-test/xwiki-platform-flamingo-theme-test-pageobjects, successfully passed the docker tests:mvn clean install -f xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-theme/xwiki-platform-flamingo-theme-test/xwiki-platform-flamingo-theme-test-docker.Manual tests, see screenshot above
Expected merging strategy