XWIKI-20183: Prototype.js breaks the standard Array.from method #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
oanalavinia
commented
Oct 4, 2022
oanalavinia
commented
- save and restore the native Array.from implementation
* save and restore the native Array.from implementation
* forgot to add the needed license header
|
Thanks! Out of curiosity, did you check with Mathjax v3.x? |
manuelleduc
reviewed
Oct 4, 2022
...platform-web/xwiki-platform-web-war/src/main/webapp/resources/js/xwiki/prototypeJSPatches.js
Show resolved
Hide resolved
Yes, and it fixes the problem :) |
* add explaining comment
manuelleduc
approved these changes
Oct 4, 2022
manuelleduc
pushed a commit
that referenced
this pull request
Oct 5, 2022
* save and restore the native Array.from implementation
manuelleduc
pushed a commit
that referenced
this pull request
Oct 5, 2022
* save and restore the native Array.from implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.