Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rvalue qualified xstrided_view_base::storage #2413

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AntoinePrv
Copy link
Contributor

Checklist

  • The title and commit message(s) are descriptive.
  • Small commits made to fix your PR have been squashed to avoid history pollution.
  • Tests have been added for new features or bug fixes.
  • API of new functions and classes are documented.

Description

Fixes #2401

@AntoinePrv AntoinePrv marked this pull request as draft July 13, 2021 19:42
@AntoinePrv
Copy link
Contributor Author

@JohanMabille , I haven't been able to figure out this build error:

.../include/xtensor/xstrided_view_base.hpp:316:11: error: rvalue reference to type
'xt::xstrided_view_base<... >::storage_type' (aka 'xt::uvector<int, std::allocator<int> >')
cannot bind to lvalue of type 'xt::uvector<int, std::allocator<int> >'

I (sort of) understand rvalue references cannot bind to lvalue, but I don't understand why this is happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rvalue overload for xcontainer::storage
1 participant