Fixed ZipArchiveFileSystem and project warnings #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Nice, when that's released I can hopefully get rid of the funny construct to use the netstandard version instead of net4.5 :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79
Fixes #81
This PR fixes all the warnings in the Zio project. While doing so, I got motivated to fix up the ZipArchive... 😅
Before
_entrieswas only used for case insensitive paths, now it's always filled with the key as UPath so we always know it's/. This fixed #79. For this to work I created UPathComparer with OrdinalIgnoreCase for case insensitive paths.I've also created a method called
ZipArchiveFileSystem.Save(). The only way to save the ZIP archive is to dispose the ZIP archive, so it closes and re-opens the ZIP archive when possible. This is the only way I can find how we can resolve this.I've created a ZIP-file in Windows and Linux (WSL2) to validate if the ZipArchiveFileSystem can read both.