tentative fork repro test #534
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrisch
reviewed
Nov 13, 2024
| await alix.conversations.sync() | ||
| await syncClientAndGroup(alix) | ||
|
|
||
| // NB => if we don't use Promise.all but a loop, we don't get a fork |
There was a problem hiding this comment.
If we use Promise.all we typically get a fork, the double negatives are confusing me 😆
So probably a race condition, but I guess where.
What we need to confirm from additional tests is:
- If we have 2 clients of the same inboxId removing members at the same time does it fork?
- If we have 2 clients with 2 different inboxIds does it fork?
If no to both then probably something to sure up on the SDK side
|
Looks like when running removals in parallel, the removal initiating client is processing their own removal commit as an external envelope which is leading to an openmls surrounding libxmtp snippet from the failed run: happy path libxmtp logs when remove in parallel is set to false: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentative fork repro test
When adding users to a group then removing multiple users at the same time using
Promise.all, sometimes it appears that the two initial members get forkedI'm not 100% sure this is exactly a fork but it looks like it because, once it's forked, I can try like 5 times, syncing the client & the group, but no messages go through
Logs of a non forked run:
Logs of a forked run: