Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents future migrations from hitting error #1344

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cameronvoell
Copy link
Contributor

Fixes #1339

currently on main branch cargo run --bin update-schema --features update-schema from xmtp_mls directory creates the following code diff:
https://github.com/xmtp/libxmtp/compare/cv/test-migration-on-main?expand=1#diff-bd2907561f23f5c88f95cebd28c7a4bb56585017a04c75fbce3eff3997863788

@cameronvoell cameronvoell requested a review from a team as a code owner November 26, 2024 17:59
@insipx
Copy link
Contributor

insipx commented Nov 26, 2024

Since its not the first time we're running into this, could be worth adding the extra derives on StoredGroup to avoid the ugly error

#[derive(Selectable) + #[diesel(check_for_backend(crate::storage::sqlite::Sqlite))]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: db application code out of sync with migrations - error trait bound is not satisfied.
2 participants