Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve copy pdb with cmake & ninja package #5877

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Improve copy pdb with cmake & ninja package #5877

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1609c2
Improve cmake & ninja cpoy pdb
star-hengxing Nov 23, 2024
b293043
improve find string
star-hengxing Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions xmake/modules/package/tools/cmake.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,9 +471,15 @@ function _get_configs_for_windows(package, configs, opt)
elseif package:has_runtime("MDd") then
table.insert(configs, "-DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreadedDebugDLL")
end
if not opt._configs_str:find("CMAKE_COMPILE_PDB_OUTPUT_DIRECTORY") then
table.insert(configs, "-DCMAKE_COMPILE_PDB_OUTPUT_DIRECTORY=pdb")

local pdb_dir = path.unix(path.join(os.curdir(), "pdb"))
if not opt._configs_str:find("CMAKE_COMPILE_PDB_OUTPUT_DIRECTORY", 1, true) then
table.insert(configs, "-DCMAKE_COMPILE_PDB_OUTPUT_DIRECTORY=" .. pdb_dir)
end
if not opt._configs_str:find("CMAKE_PDB_OUTPUT_DIRECTORY", 1, true) then
table.insert(configs, "-DCMAKE_PDB_OUTPUT_DIRECTORY=" .. pdb_dir)
end

if package:is_cross() then
_get_configs_for_cross(package, configs, opt)
else
Expand Down
Loading