Resolve build error C2065: 'M_PI': undeclared identifier` (fix issue #49) #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See xiph#49 for details
tmatth
reviewed
Oct 4, 2024
| #ifdef HAVE_CONFIG_H | ||
| #include "config.h" | ||
| #endif | ||
|
|
||
| #include "speex/speex_resampler.h" | ||
| #include <stdio.h> | ||
| #include <math.h> | ||
| #include <stdlib.h> |
There was a problem hiding this comment.
The current convention (for broadest portability) used in xiph projects is to define M_PI as needed, e.g.
diff --git a/libspeexdsp/testresample2.c b/libspeexdsp/testresample2.c
index 99a830d..5f5b938 100644
--- a/libspeexdsp/testresample2.c
+++ b/libspeexdsp/testresample2.c
@@ -39,6 +39,10 @@
#include <math.h>
#include <stdlib.h>
+#ifndef M_PI
+#define M_PI 3.14159265358979323846
+#endif
+
#define PERIOD 32
#define INBLOCK 1024
#define RATE 48000See e.g.,
speexdsp/libspeexdsp/resample.c
Line 84 in dbd421d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to issue #49
This is subject to maintainer choosing another way
cc @tmatth