Add tests for duplicate dims in batch_dims and input_dims #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersy005
reviewed
Dec 16, 2022
Co-authored-by: Anderson Banihirwe <[email protected]>
norlandrhagen
approved these changes
Dec 16, 2022
Co-authored-by: Raphael Hagen <[email protected]>
Good idea, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR adds two tests for BatchGenerator when there are one or more dimensions included in both input_dims and batch_dims. The testing utilities are updated to account for this case. The tests currently fail due to #131, but including them will be helpful for finishing #132.