Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let TensorFlow accessor and data loader handle either xarray.DataArray or xarray.Dataset inputs #107
Let TensorFlow accessor and data loader handle either xarray.DataArray or xarray.Dataset inputs #107
Changes from 4 commits
f063241
261b911
d146227
2ab5cf3
55bc534
f8b8bcb
e4f6ef1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure that we want to use
keras
instead oftensorflow
as the accessor name (considering that the returned tensors aretf.Tensor
objects)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait, I guess we're using
xbatcher.loaders.keras.CustomTFDataset
in the dataloader at https://github.com/xarray-contrib/xbatcher/blob/ed45a99da54503de2e94cc90f12510f590ea9be6/doc/api.rst#dataloaders, so might as well stick withkeras
to be consistent (unless anyone is keen to change everything totensorflow
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with your point. What do you and @norlandrhagen think of
tf
for the accessor name andTFAccessor
as the class name to keep it shorter?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedbaack @weiji14 @maxrjones
Good point on the naming. I can update the accessor name and class name. Should up update the data loader naming(
xbatcher.loaders.keras.CustomTFDataset
) in this PR?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rename the tensorflow dataloader in a separate PR (so that it shows up in the changelog as a backward incompatible change).