use mapbox/earcut library for efficient earclipping #581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the earclipping algorithm with a more efficient earclipping library available here:
https://github.com/mapbox/earcut
The main advantage is handling of corner cases and large polygons.
The dedicated library is compact and included directly in EarClipping.js but it could be moved to a separate file.
There is some required remapping of input and output to and from the library which could be optimized by directly using the provided x3dom linkedlist.
The library also deals with holes in polygons if needed elsewhere (fonts?) at some point.
This user script allows for testing:
https://gist.githubusercontent.com/andreasplesch/42d6405d0de8cc2472b8/raw/x3domEarcut.user.js