Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted .apply to iterations in the function utils.toBase64() #472

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

kkmanos
Copy link
Member

@kkmanos kkmanos commented Dec 2, 2024

Even though .apply was returning correct results, after extending the size of the privateData column a change in the toBase64 is required to support larger inputs even though the performance might be reduced for small inputs.

@kkmanos kkmanos requested a review from emlun December 2, 2024 08:37
Copy link
Member

@emlun emlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@kkmanos kkmanos marked this pull request as ready for review December 2, 2024 10:38
@kkmanos kkmanos merged commit e1dedd1 into master Dec 2, 2024
4 checks passed
@kkmanos kkmanos deleted the iterative-tobase64 branch December 2, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants