Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add print layout with ability to hide #816

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Add print layout with ability to hide #816

merged 4 commits into from
Dec 2, 2024

Conversation

joko3ono
Copy link
Collaborator

This PR aims to resolve issue #815.

I've added a print layout to make the search results more readable when printed. Here is the result for printing all pages.

print-all.pdf
Screenshot 2024-11-12 at 11 27 15

With the ability to fold certain content, I used this feature to completely hide folded sections in print. Here’s an example where the "Graphical Overview" section is folded.

exclude-circos.pdf
Screenshot 2024-11-12 at 11 27 39

@yannickwurm
Copy link
Member

yannickwurm commented Nov 12, 2024

Thank you Joko - the way you hide the things is definitely the way to do it - thanks for that initiative

what would happen if an American tries printing? (they are typically US Letter paper size users)Screenshot 2024-11-12 at 14 08 03

@joko3ono
Copy link
Collaborator Author

@yannickwurm it should be not a problem with current, but I'm going to make small adjustments to the stylesheet

public/js/collapse_preferences.js Outdated Show resolved Hide resolved
public/js/grapher.js Outdated Show resolved Hide resolved
@joko3ono joko3ono requested a review from tadast November 19, 2024 22:36
Copy link
Collaborator

@tadast tadast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@joko3ono joko3ono requested a review from tadast November 27, 2024 04:53
@tadast tadast merged commit 191affb into master Dec 2, 2024
5 checks passed
@tadast tadast deleted the print-layout branch December 2, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants