Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_connection doesn't return a connection #7

Open
kjsanger opened this issue Sep 23, 2024 · 0 comments
Open

get_connection doesn't return a connection #7

kjsanger opened this issue Sep 23, 2024 · 0 comments

Comments

@kjsanger
Copy link
Member

get_connection doesn't return a connection, but rather creates and returns a new Session

https://github.com/wtsi-npg/npg_notifications/blob/4e45baa34602b5e0785d7d05ec9880f7cf30c50e/src/npg_notify/db/utils.py#L50C5-L50C19

This is mentioned in the docstring, but a better name would mention session e.g. open_session, new_session, session etc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kjsanger