Improve integration tests on the definedBy authentication property #21315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thisara-Welmilla
force-pushed
the
improve-authentication-api-integration-test
branch
2 times, most recently
from
4b6140e
to
ffdf6ef
Compare
Thisara-Welmilla
force-pushed
the
improve-authentication-api-integration-test
branch
from
ffdf6ef
to
7a3b410
Compare
malithie
previously approved these changes
Oct 14, 2024
ashanthamara
approved these changes
Oct 19, 2024
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Oct 19, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11416005922
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
With the above issue, following APIs response body will be changed.
For the following APIs,
definedBytype property will be returned in the response payload for all authenticators./api/server/v1/authenticators/api/server/v1/configs/authenticators/api/server/v1/identity-providers/{Identity_Proivder_Id}/api/server/v1/identity-providers/{Identity_Proivder_Id}/federated-authenticators/{Authenticator_ID}For all existing authenticators, this value will be SYSTEM.
With this PR, we improve integration tests check the whether
definedByproperty in available in the above payload responses.