-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI support for Filtering Organizations by Metadata Attributes #6667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HasiniSama
force-pushed
the
meta-attribute-get
branch
from
July 24, 2024 08:44
63418e5
to
7f7d7d5
Compare
Let's add changeset and resolve the merge conflicts for the PR builder to start. |
features/admin.core.v1/components/advanced-search-with-basic-filters.tsx
Outdated
Show resolved
Hide resolved
HasiniSama
force-pushed
the
meta-attribute-get
branch
2 times, most recently
from
July 30, 2024 04:41
5720257
to
dc9ac27
Compare
Also let's check whether we can define unit tests to validate the frontend behaviour introduced with this change. |
pavinduLakshan
changed the title
UI updated for Filtering Organizations by Metadata Attributes
UI support for Filtering Organizations by Metadata Attributes
Jul 30, 2024
HasiniSama
force-pushed
the
meta-attribute-get
branch
from
August 5, 2024 09:23
aa62f68
to
4c39c64
Compare
features/admin.core.v1/components/advanced-search-with-basic-filters.tsx
Outdated
Show resolved
Hide resolved
features/admin.organizations.v1/components/meta-attribute-auto-complete.tsx
Outdated
Show resolved
Hide resolved
features/admin.organizations.v1/components/meta-attribute-auto-complete.tsx
Outdated
Show resolved
Hide resolved
HasiniSama
force-pushed
the
meta-attribute-get
branch
from
August 5, 2024 16:51
3cd196d
to
315477e
Compare
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
pavinduLakshan
approved these changes
Aug 5, 2024
This was referenced Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The UI will be updated as follows:
The drop-down for selecting a filter attribute will contain an option labeled "Meta Attributes".
A new field will appear below it to select the specific metadata attribute key. This field will include an autocomplete component, allowing users to search for metadata attributes by name before filtering.
Related Issues
Related PRs
Checklist
Security checks