Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the /identity-providers/ API to manage user-defined federated authenticators. #735

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Update the /identity-providers/ API to manage user-defined federated authenticators. #735

wants to merge 7 commits into from

Conversation

Thisara-Welmilla
Copy link
Contributor

@Thisara-Welmilla Thisara-Welmilla commented Nov 7, 2024 •
edited
Loading

Issue:

This PR introduces improvements to the following APIs for managing user-defined federated authenticators:

  • /identity-providers: Updated the request body for the PUT request to accept both authenticator configuration models.
  • /identity-providers/{identity-provider-id}/federated-authenticators: Updated the request body for the PUT request to accept both authenticator configuration models.
  • /identity-providers/{identity-provider-id}/federated-authenticators/{federated-authenticator-id}: Updated the response and request bodies for both GET and PUT requests to accommodate both models.

Service layer PR:

@Thisara-Welmilla Thisara-Welmilla force-pushed the add-API-support-create-user-def-auth-fed branch from 64340ab to a2fb35c Compare November 7, 2024 16:43
@Thisara-Welmilla Thisara-Welmilla marked this pull request as ready for review November 11, 2024 03:19
This was referenced Nov 11, 2024
Open
Open
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-API-support-create-user-def-auth-fed branch from 05be0f7 to cfc2832 Compare November 11, 2024 17:04
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-API-support-create-user-def-auth-fed branch from 553c635 to 88ce34f Compare November 12, 2024 04:54
@Thisara-Welmilla Thisara-Welmilla changed the title Update /identity-provider/ API to manage user defined federated authenticators. Update the /identity-providers/ API to manage user-defined federated authenticators. Nov 12, 2024
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-API-support-create-user-def-auth-fed branch 2 times, most recently from 2d0d880 to 65d508c Compare November 12, 2024 09:27
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-API-support-create-user-def-auth-fed branch from 65d508c to 6d3a143 Compare November 12, 2024 09:49
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-API-support-create-user-def-auth-fed branch 7 times, most recently from 6500b42 to f8ad6fb Compare November 13, 2024 12:37
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-API-support-create-user-def-auth-fed branch from f8ad6fb to b4df83f Compare November 13, 2024 12:59
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-API-support-create-user-def-auth-fed branch 5 times, most recently from 49d2d0a to f1c9ce8 Compare November 15, 2024 12:00
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-API-support-create-user-def-auth-fed branch 2 times, most recently from 556500c to a0dad0a Compare November 20, 2024 08:07
malithie
malithie previously approved these changes Nov 22, 2024
View reviewed changes
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-API-support-create-user-def-auth-fed branch from a0dad0a to 455d408 Compare November 23, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malithie malithie malithie left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thisara-Welmilla @malithie