Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the Action Management API to reject inflow action types such as authentication. #713

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

malithie
Copy link
Member

@malithie malithie commented Oct 17, 2024

Purpose

Resolves wso2/product-is#21384

Approach

This PR updates following,

  • Updates action management error codes such that they don't overlap with the error codes from core action management service
  • Updates the OpenAPI contract to denote that in-flow action types are not allowed

System Impact: Nothing considerable

Customer Impact:

  • Change the error codes for action management API
  • Given that this feature is still in beta these API contract changes are acceptable.

ashanthamara
ashanthamara previously approved these changes Oct 18, 2024
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11397535712

ashanthamara
ashanthamara previously approved these changes Oct 18, 2024
@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11397535712
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11397535712

ashanthamara
ashanthamara previously approved these changes Oct 18, 2024
@malithie malithie changed the title Updates the Action Management API to manage only pre-post action types. Updates the Action Management API to reject inflow action types such as authentication. Oct 18, 2024
@malithie malithie merged commit 9d68644 into wso2:master Oct 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Categorize action types as prepost and inflow
3 participants