Add api support to try out branding AI feature #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sahandilshan
force-pushed
the
master2
branch
from
c040afc
to
6864024
Compare
sahandilshan
requested review from
dhaura,
pamodaaw,
ShanChathusanda93 and
ZiyamSanthosh
pamodaaw
reviewed
Oct 7, 2024
| "Error while updating custom text preference configurations for organization: %s."), | ||
| ERROR_CODE_ERROR_GETTING_BRANDING_RESULT_STATUS("65009", | ||
| "Error while getting branding preference generation result status.", | ||
| "Error while retrieving branding preference generation result status for operation."), |
There was a problem hiding this comment.
Can't we add any information specific to the action in the error description?
| if (taskOperationService != null) { | ||
| this.brandingAiPreferenceManager = taskOperationService; | ||
| } else { | ||
| throw new Exception("Unable to retrieve ConfigurationManager service."); |
There was a problem hiding this comment.
Suggested change
| throw new Exception("Unable to retrieve ConfigurationManager service."); | |
| throw new Exception("Unable to retrieve BrandingAIPreferenceManager service."); |
| */ | ||
| public class BrandingAIPreferenceManagementService { | ||
|
|
||
| private static final Log log = LogFactory.getLog(BrandingAIPreferenceManagementService.class); |
There was a problem hiding this comment.
Suggested change
| private static final Log log = LogFactory.getLog(BrandingAIPreferenceManagementService.class); | |
| private static final Log LOG = LogFactory.getLog(BrandingAIPreferenceManagementService.class); |
| BrandingGenerationRequestModel brandingGenerationRequestModel) { | ||
|
|
||
| try { | ||
| String operationId = BrandingPreferenceServiceHolder.getBrandingPreferenceAiManager() |
There was a problem hiding this comment.
can BrandingPreferenceServiceHolder.getBrandingPreferenceAiManager() return null?
| public BrandingGenerationStatusModel getBrandingPreferenceGenerationStatus(String operationId) { | ||
|
|
||
| try { | ||
| Object generationStatus = BrandingPreferenceServiceHolder.getBrandingPreferenceAiManager() |
There was a problem hiding this comment.
can BrandingPreferenceServiceHolder.getBrandingPreferenceAiManager() be null?
| operationId: getBrandingGenerationStatus | ||
| summary: Get the status of a branding generation operation. | ||
| description: | | ||
| This API endpoint return the status of the AI branding generation process that initiated using the `/generate` endpoint.<br/> |
There was a problem hiding this comment.
Suggested change
| This API endpoint return the status of the AI branding generation process that initiated using the `/generate` endpoint.<br/> | |
| This API endpoint returns the status of the AI branding generation process that is initiated using the `/generate` endpoint.<br/> |
Comment on lines
+209
to
+211
|
|
||
|
|
||
|
|
|
|
||
| if (object instanceof Map) { | ||
| Map<String, Object> map = new HashMap<>(); | ||
| for (Map.Entry<String, Object> entry : ((Map<String, Object>) object).entrySet()) { |
There was a problem hiding this comment.
Can we guarantee that the entry is always <String, Object>
| return new HashMap<>(); | ||
| } | ||
|
|
||
| private static Object[] convertListToArray(List<?> list) { |
There was a problem hiding this comment.
can we optimize this method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
Related Issue(s)
Related PR(s)
*** Note: Should merge after merging wso2-extensions/identity-branding-preference-management#46