Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Password Recovery Connector Configuration Updates #621

Merged
merged 6 commits into from
Jun 26, 2024

Conversation

RushanNanayakkara
Copy link
Contributor

@RushanNanayakkara RushanNanayakkara commented Jun 13, 2024

Purpose

Under the feature "SMS OTP For Password Recovery" the recovery connector is introduced with two new configs. "Recovery.Notification.Password.emailLink.Enable" and "Recovery.Notification.Password.smsOtp.Enable". These new configs and the existing 'Recovery.Notification.Password.Enable" configuration are related hence configurations need to be in a valid state. This PR adds the validation to the connector configuration update requests.
Invalid states being tested.

  • Connector is set to disable but one or more recovery options are set to be enabled.
  • Connector is set to enable but no recovery options are set to be enabled.

Related PRs

Related Issues

@@ -1,5 +1,5 @@
/*
* Copyright (c) 2019, WSO2 LLC. (http://www.wso2.com).
* Copyright (c) 2024, WSO2 LLC. (http://www.wso2.com).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we are updating the date here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to change as 2019-2024 as we include year range in the header. Made the change with d093e67

@RushanNanayakkara RushanNanayakkara merged commit 7eec8e0 into wso2:master Jun 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants