Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Branding Management API Definition to Include restrictToPublished Query Paramater #4701

Merged

Conversation

dhaura
Copy link
Contributor

@dhaura dhaura commented Aug 9, 2024

Purpose

A new query parameter (restrictToPublished) to the branding preference resolve GET endpoint is introduced, in order to enable the resolution of branding preferences using only published preferences. The purpose of this PR is to add this newly introduced query parameter into branding management API docs.

By adding the restrictToPublished query parameter, users can specify whether to retrieve branding preferences only from published sources or from both published and unpublished preferences.

Example Usage:

curl --location '{base-url}/api/server/v1/branding-preference/resolve?locale={locale}&name={name}&type={branding-type}&restrictToPublished={true/false}' 

EX:

curl --location 'https://localhost:9443/t/carbon.super/api/server/v1/branding-preference/resolve?locale=en-US&name=e3548660-6ff9-4a39-acd6-d4071d6a6e69&type=APP&restrictToPublished=true' 

Parameter Behavior of restrictToPublished

  • true: Returns resolved branding preferences considering only published preferences.
  • false: Returns resolved branding preferences considering both published and unpublished preferences.
  • Not set: Defaults to false, considering both published and unpublished preferences.

Related Issues

Related PRs

AnuradhaSK
AnuradhaSK previously approved these changes Aug 9, 2024
name: restrictToPublished
required: false
description: |
Specifies whether to use only published branding preferences for resolving.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Specifies whether to use only published branding preferences for resolving.
Specifies whether to limit resolving to published branding preferences.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed with 169604e

@himeshsiriwardana himeshsiriwardana merged commit 9dbb874 into wso2:master Sep 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants